This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Conversation
jcjimenez
approved these changes
Nov 28, 2017
| FROM node:6.12.0 | ||
|
|
||
| ADD . /app | ||
| WORKDIR /app |
There was a problem hiding this comment.
I'm wondering if instead of doing the ADD+WORKDIR thing, we do something with volumes: like this in the docker-compose.yml file instead:
ports:
- 8888:80
volumes:
- ./:/app
This way, any changes done from the container can be used or committed to git. What do you think?
Contributor
Author
There was a problem hiding this comment.
Sounds great. I don't have any experience with using volumes, so I'd appreciate a PR from which I can learn :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CatalystCode/project-fortis-pipeline#228