Skip to content
This repository has been archived by the owner. It is now read-only.

Dockerize #107

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Nov 28, 2017

@c-w c-w requested a review from jcjimenez Nov 28, 2017

@jcjimenez
Copy link

left a comment

LGTM

FROM node:6.12.0

ADD . /app
WORKDIR /app

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Nov 28, 2017

I'm wondering if instead of doing the ADD+WORKDIR thing, we do something with volumes: like this in the docker-compose.yml file instead:

    ports:
        - 8888:80
    volumes:
      - ./:/app

This way, any changes done from the container can be used or committed to git. What do you think?

This comment has been minimized.

Copy link
@c-w

c-w Nov 28, 2017

Author Member

Sounds great. I don't have any experience with using volumes, so I'd appreciate a PR from which I can learn :)

@c-w c-w merged commit 5eea24b into master Nov 28, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details

@c-w c-w deleted the dockerize branch Nov 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.