Skip to content
This repository has been archived by the owner. It is now read-only.

Remove usage of TilesSchema byLocations endpoints #11

Merged
merged 4 commits into from Aug 9, 2017
Merged

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 28, 2017

This is a sister-change to pull request #10, see the the description of that change for further information.

This is a sister-change to pull request
#10, see
the the description of that change for further information.
@c-w c-w requested a review from erikschlegel Jul 28, 2017
Smarker
Smarker approved these changes Aug 7, 2017
Copy link
Contributor

@Smarker Smarker left a comment

LGTM - with comments

SERVICES.getHeatmapTiles(siteKey, state.timespanType, zoom, state.categoryValue.name, state.datetimeSelection,
bbox, Array.from(state.termFilters), [state.selectedLocationCoordinates], Actions.DataSources(state.dataSource),
SERVICES.getHeatmapTiles(siteKey, state.timespanType, zoom, state.categoryValue.name, state.datetimeSelection,
bbox, Array.from(state.termFilters), undefined, Actions.DataSources(state.dataSource),
Copy link
Contributor

@Smarker Smarker Aug 7, 2017

Would it be possible to remove this undefined parameter? (see #10)

Copy link
Contributor Author

@c-w c-w Aug 7, 2017

Done in 18a7572.

Smarker
Smarker approved these changes Aug 7, 2017
Copy link
Contributor

@Smarker Smarker left a comment

LGTM

Copy link
Collaborator

@erikschlegel erikschlegel left a comment

LGTM

@c-w c-w merged commit decd84a into master Aug 9, 2017
@c-w c-w deleted the remove-bylocations-2 branch Aug 9, 2017
c-w added a commit that referenced this issue Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants