Skip to content
This repository has been archived by the owner. It is now read-only.

Pass-through conjunctivetopics to GQL backend #15

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jul 31, 2017

Not sure why we're using mainEdge: $additionalTerms for the timeseries and popularLocations endpoints but mainEdge: $selectedTerm for the topSources endpoint.

Also not sure why we're ignoring the mainEdge argument which is passed into the function and used by most other services to pass the conjunctivetopics to the backend. Could use some help understanding this.

@c-w c-w requested a review from erikschlegel Jul 31, 2017

c-w added a commit to CatalystCode/project-fortis-services that referenced this pull request Jul 31, 2017

Add mainEdge to popularLocations
This is the backend change for the following frontend change:
CatalystCode/project-fortis-interfaces#15
@erikschlegel
Copy link
Collaborator

left a comment

LGTM

Pass-through conjunctivetopics to GQL backend
Not sure why we're using `mainEdge: $additionalTerms` for the timeseries
and popularLocations endpoints but `mainEdge: $selectedTerm` for the
topSources endpoint.

Also not sure why we're ignoring the *mainEdge* argument which is passed
into the function and used by most other services to pass the
conjunctivetopics to the backend.

@c-w c-w force-pushed the locations-by-terms branch from eda9611 to 6ef5819 Aug 9, 2017

@c-w c-w merged commit 92ead09 into master Aug 9, 2017

@c-w c-w deleted the locations-by-terms branch Aug 9, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.