This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Pass-through conjunctivetopics to GQL backend#15
Merged
Conversation
c-w
added a commit
to CatalystCode/project-fortis-services
that referenced
this pull request
Jul 31, 2017
This is the backend change for the following frontend change: CatalystCode/project-fortis-interfaces#15
Not sure why we're using `mainEdge: $additionalTerms` for the timeseries and popularLocations endpoints but `mainEdge: $selectedTerm` for the topSources endpoint. Also not sure why we're ignoring the *mainEdge* argument which is passed into the function and used by most other services to pass the conjunctivetopics to the backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why we're using
mainEdge: $additionalTermsfor the timeseries and popularLocations endpoints butmainEdge: $selectedTermfor the topSources endpoint.Also not sure why we're ignoring the mainEdge argument which is passed into the function and used by most other services to pass the conjunctivetopics to the backend. Could use some help understanding this.