This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Pass-through originalSource for Tiles schema #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The originalSource gets set in the DataStore via the handleReloadChartData method which is called through the reloadVisualizationState action. Amonst others, this action is wired up to the onClick event in the TopSourcesChart so this should be sufficient for us to wire through the particular source on which the user clicked in the top sources donut chart to the backend (so that we can going forward only fetch the events pertaining to the source that the user selected, e.g. only Tweets from AlJazeera). Note that there are still other locations where this data needs to be passed through too. This commit just cares about the Tiles schema.
c-w
added a commit
to CatalystCode/project-fortis-services
that referenced
this pull request
Jul 31, 2017
This is the backend change for the frontend change in CatalystCode/project-fortis-interfaces#18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The originalSource gets set in the DataStore via the handleReloadChartData method which is called through the reloadVisualizationState action. Amonst others, this action is wired up to the onClick event in the TopSourcesChart so this should be sufficient for us to wire through the particular source on which the user clicked in the top sources donut chart to the backend (so that we can going forward only fetch the events pertaining to the source that the user selected, e.g. only Tweets from AlJazeera).
Note that there are still other locations where this data needs to be passed through too. This commit just cares about the Tiles schema.