Skip to content
This repository has been archived by the owner. It is now read-only.

Pass-through originalSource for Tiles schema #18

Merged
merged 1 commit into from Aug 9, 2017
Merged

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 31, 2017

The originalSource gets set in the DataStore via the handleReloadChartData method which is called through the reloadVisualizationState action. Amonst others, this action is wired up to the onClick event in the TopSourcesChart so this should be sufficient for us to wire through the particular source on which the user clicked in the top sources donut chart to the backend (so that we can going forward only fetch the events pertaining to the source that the user selected, e.g. only Tweets from AlJazeera).

Note that there are still other locations where this data needs to be passed through too. This commit just cares about the Tiles schema.

The originalSource gets set in the DataStore via the
handleReloadChartData method which is called through the
reloadVisualizationState action. Amonst others, this action is wired up
to the onClick event in the TopSourcesChart so this should be sufficient
for us to wire through the particular source on which the user clicked
in the top sources donut chart to the backend (so that we can going
forward only fetch the events pertaining to the source that the user
selected, e.g. only Tweets from AlJazeera).

Note that there are still other locations where this data needs to be
passed through too. This commit just cares about the Tiles schema.
@c-w c-w requested a review from erikschlegel Jul 31, 2017
c-w added a commit to CatalystCode/project-fortis-services that referenced this issue Jul 31, 2017
This is the backend change for the frontend change in
CatalystCode/project-fortis-interfaces#18
Copy link
Collaborator

@erikschlegel erikschlegel left a comment

LGTM

@c-w c-w merged commit c3133ac into master Aug 9, 2017
@c-w c-w deleted the externalsourceid-passthrough branch Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants