Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Some more cleanups for heatmap#29

Merged
c-w merged 1 commit intomasterfrom
cleanup-heatmap
Aug 23, 2017
Merged

Some more cleanups for heatmap#29
c-w merged 1 commit intomasterfrom
cleanup-heatmap

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Aug 23, 2017

No functional change, just some refactoring:

  • Convert let to const where possible
  • Extract helper methods
  • Make constant naming consistent
  • Prefer early-return over nesting

No functional change, just some refactoring:

- Convert `let` to `const` where possible
- Extract helper methods
- Make constant naming consistent
- Prefer early-return over nesting
@c-w c-w requested a review from Smarker August 23, 2017 22:16
Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 997b797 into master Aug 23, 2017
@c-w c-w deleted the cleanup-heatmap branch August 23, 2017 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants