This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Remove a few files that are no longer used#55
Merged
Conversation
c-w
force-pushed
the
remove-outdated-files
branch
from
cbb30f4 to
060b5be
Compare
erikschlegel
suggested changes
Sep 14, 2017
erikschlegel
left a comment
erikschlegel
left a comment
Collaborator
There was a problem hiding this comment.
We need to find a better solution for serving up the image assets. Until we do, can you add the image assets back to the repo.
erikschlegel
left a comment
erikschlegel
left a comment
Collaborator
There was a problem hiding this comment.
Isnt public/index.html our main html file?
erikschlegel
left a comment
erikschlegel
left a comment
Collaborator
There was a problem hiding this comment.
For example, public/images/OCHA_Logo.png is the main logo we render on the site.
Contributor
Author
c-w
force-pushed
the
remove-outdated-files
branch
from
0249659 to
5f8d77a
Compare
erikschlegel
approved these changes
Sep 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional change: just removing some unused files that may be confusing to developers and add overhead in larger-scale refactorings.
Also removing the deployment files since we're now deploying via deis.