This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Add topics chips #64
Merged
Add topics chips #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-w
force-pushed
the
add-topics-chips
branch
3 times, most recently
from
7b2a34f to
f29c6cf
Compare
c-w
force-pushed
the
add-topics-chips
branch
from
f29c6cf to
24f5b1b
Compare
erikschlegel
approved these changes
Sep 15, 2017
| let chips = []; | ||
| const { dataSource, externalsourceid, selectedplace } = this.props; | ||
| const { dataSource, externalsourceid, selectedplace, maintopic, termFilters } = this.props; | ||
| const chips = []; |
Collaborator
There was a problem hiding this comment.
why is chips defined as a const if it's mutable?
Contributor
Author
There was a problem hiding this comment.
It's a mutable object, not a mutable reference. Same reason why this works in Java:
final List<String> foo = new ArrayList<>();
// this works since foo is a mutable type
foo.add("something");
// this doesn't work since foo is an immutable reference
foo = new ArrayList<>();
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: there isn't an "x" to remove the maintopic filter because we always require the maintopic to be defined in the graphql queries.