Skip to content
This repository has been archived by the owner. It is now read-only.

Simplify typeahead suggestions fetcher #65

merged 2 commits into from Sep 15, 2017


None yet
2 participants
Copy link

commented Sep 15, 2017

No functional change, just removing some unnecessary arguments in the suggestions fetcher callback signature.

@c-w c-w requested a review from erikschlegel Sep 15, 2017

c-w added some commits Sep 15, 2017

Fix bad variable name
The method with the same interface on L56 above and the call-site on L77
below clearly state that the second argument to the method is the
featureservicenamespace. As such, the argument name should reflect this.
Simplify suggestion fetcher interface
No need to pass the featureservicenamespace in the method signature if
we can just access it via the props.

@c-w c-w force-pushed the simplify-typeahead-suggestions-fetcher branch from 52971ec to 32b9d24 Sep 15, 2017

@c-w c-w merged commit 6975b05 into master Sep 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@c-w c-w deleted the simplify-typeahead-suggestions-fetcher branch Sep 15, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.