This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Simplify typeahead suggestions fetcher - #65
Merged
Conversation
The method with the same interface on L56 above and the call-site on L77 below clearly state that the second argument to the method is the featureservicenamespace. As such, the argument name should reflect this.
No need to pass the featureservicenamespace in the method signature if we can just access it via the props.
c-w
force-pushed
the
simplify-typeahead-suggestions-fetcher
branch
from
September 15, 2017 12:08
52971ec to
32b9d24
Compare
erikschlegel
approved these changes
Sep 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional change, just removing some unnecessary arguments in the suggestions fetcher callback signature.