Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Simplify typeahead suggestions fetcher #65

merged 2 commits into from Sep 15, 2017


Copy link

@c-w c-w commented Sep 15, 2017

No functional change, just removing some unnecessary arguments in the suggestions fetcher callback signature.

The method with the same interface on L56 above and the call-site on L77
below clearly state that the second argument to the method is the
featureservicenamespace. As such, the argument name should reflect this.
No need to pass the featureservicenamespace in the method signature if
we can just access it via the props.
@c-w c-w force-pushed the simplify-typeahead-suggestions-fetcher branch from 52971ec to 32b9d24 Compare September 15, 2017 12:08
@c-w c-w merged commit 6975b05 into master Sep 15, 2017
@c-w c-w deleted the simplify-typeahead-suggestions-fetcher branch September 15, 2017 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants