Skip to content
This repository has been archived by the owner. It is now read-only.

Fetch stream values from graphql #68

Merged
merged 2 commits into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Sep 15, 2017

image

This implementation is a bit of a hack, however doing this the right way (pulling the DATA_SOURCES into the DataStore) is quite a lot of effort because the constants.DATA_SOURCES is being used promiscuously in the code-base. I spent about an hour cleaning this up but it ended up being a reasonably large change (i.e., technical risk) so that it's worth doing this temporary hack for now.

There currently is a bug in the data: the pipelinekey in Cassandra is all-lowercase like "twitter" but the frontend assumes that it's capitalized like "Twitter". This issue will take care of itself once we update the streams table in Cassandra. More generally speaking, I had to edit quite a few of the columns in the streams table... we should start paying attention to that table and insert proper values into it instead of dummy values.

c-w added some commits Sep 15, 2017

Fetch stream values from graphql
There currently is a bug in the data: the pipelinekey in Cassandra is
all-lowercase like "twitter" but the frontend assumes that it's
capitalized like "Twitter". This issue will take care of itself once we
update the streams table in Cassandra. More generally speaking, I had to
edit quite a few of the columns in the streams table... we should start
paying attention to that table and insert propert values into it instead
of dummy values.

This implementation is a bit of a hack, however doing this the right way
(pulling the DATA_SOURCES into the DataStore) is quite a lot of efforts
because the constants.DATA_SOURCES is being used promiscuously in the
code-base. I spent about an hour cleaning this up but it ended up being
a reasonably large change (i.e., technical risk) so that it's worth
doing this temporary hack for now.

@c-w c-w requested review from Smarker and erikschlegel Sep 15, 2017

@erikschlegel erikschlegel merged commit 7b2a9dd into master Sep 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the dynamic-streams branch Sep 15, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.