This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Fetch stream values from graphql #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is a bit of a hack, however doing this the right way (pulling the DATA_SOURCES into the DataStore) is quite a lot of effort because the constants.DATA_SOURCES is being used promiscuously in the code-base. I spent about an hour cleaning this up but it ended up being a reasonably large change (i.e., technical risk) so that it's worth doing this temporary hack for now.
There currently is a bug in the data: the pipelinekey in Cassandra is all-lowercase like "twitter" but the frontend assumes that it's capitalized like "Twitter". This issue will take care of itself once we update the streams table in Cassandra. More generally speaking, I had to edit quite a few of the columns in the streams table... we should start paying attention to that table and insert proper values into it instead of dummy values.