This repository has been archived by the owner. It is now read-only.
Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFetch stream values from graphql #68
Conversation
c-w
added some commits
Sep 15, 2017
c-w
requested review from
Smarker and
erikschlegel
Sep 15, 2017
erikschlegel
approved these changes
Sep 15, 2017
erikschlegel
merged commit 7b2a9dd
into
master
Sep 15, 2017
c-w
deleted the
dynamic-streams
branch
Sep 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
c-w commentedSep 15, 2017
•
edited
This implementation is a bit of a hack, however doing this the right way (pulling the DATA_SOURCES into the DataStore) is quite a lot of effort because the constants.DATA_SOURCES is being used promiscuously in the code-base. I spent about an hour cleaning this up but it ended up being a reasonably large change (i.e., technical risk) so that it's worth doing this temporary hack for now.
There currently is a bug in the data: the pipelinekey in Cassandra is all-lowercase like "twitter" but the frontend assumes that it's capitalized like "Twitter". This issue will take care of itself once we update the streams table in Cassandra. More generally speaking, I had to edit quite a few of the columns in the streams table... we should start paying attention to that table and insert proper values into it instead of dummy values.