Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Fix feature-db setup script with new dump #109

Merged
merged 6 commits into from
Aug 15, 2017
Merged

Fix feature-db setup script with new dump #109

merged 6 commits into from
Aug 15, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Aug 14, 2017

A few changes were necessary to make this work with Tim's latest dump:

  1. Remove some extension points (user name, database name) as the dump assumes them
  2. Export two connection strings since the dump assumes two users being set up

Verified that the script runs without issues like so:

# these are normally be set by the fortis-deploy.sh script, setting manually for testing
region='EastUS'
resource_group='clewolff-test-db'

# call the script to create and populate the feature-db
# this takes ~30 minutes to download the database dump and a few hours to populate the db
. ./install-feature-service-db.sh "$region" "$resource_group"

# verify the connection strings; normally these would be stored in the cluster config map
echo "$FEATURE_SERVICE_DB_CONNECTION_STRING"
echo "$FEATURE_SERVICE_DB_CONNECTION_STRING_2"

c-w added 4 commits August 14, 2017 11:20
Also remove some customization points that are actually hard-coded
assumptions in the database dump
@c-w c-w requested a review from erikschlegel August 14, 2017 22:06
Copy link
Contributor

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w
Copy link
Contributor Author

c-w commented Aug 15, 2017

image

@c-w c-w merged commit 6414cab into master Aug 15, 2017
@c-w c-w deleted the feature-db branch August 15, 2017 02:09
@c-w c-w removed the in progress label Aug 15, 2017
rachelnicole pushed a commit that referenced this pull request Jan 24, 2018
Fix bug with undefined params field
rachelnicole pushed a commit that referenced this pull request Jan 24, 2018
Move Cassandra sink helper methods in scope of connection implicit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants