Skip to content
This repository has been archived by the owner. It is now read-only.

Remove pipelinekey #111

Merged
merged 2 commits into from Aug 16, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Aug 15, 2017

We query the table like so:

    SELECT *
    FROM fortis.events
    WHERE eventid = ?
    LIMIT 2

When we query the table, we don't know what pipeline the event came from (it's in the messages schema event endpoint which just retrieves an event by id). This means that either we have to ALLOW FILTERING here or we must remove the pipelinekey from the table primary key. Given that the eventids will be unique (we generate them in Spark), I don't see an issue with just removing the pipelinekey here.

@c-w c-w requested a review from erikschlegel Aug 15, 2017

@c-w c-w added the in progress label Aug 15, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit 2e4a9f8 into master Aug 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-messages-queries branch Aug 16, 2017

@c-w c-w removed the in progress label Aug 16, 2017

rachelnicole pushed a commit that referenced this pull request Jan 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.