Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Remove pipelinekey#111

Merged
c-w merged 2 commits intomasterfrom
fix-messages-queries
Aug 16, 2017
Merged

Remove pipelinekey#111
c-w merged 2 commits intomasterfrom
fix-messages-queries

Conversation

@c-w
Copy link
Copy Markdown
Contributor

@c-w c-w commented Aug 15, 2017

We query the table like so:

    SELECT *
    FROM fortis.events
    WHERE eventid = ?
    LIMIT 2

When we query the table, we don't know what pipeline the event came from (it's in the messages schema event endpoint which just retrieves an event by id). This means that either we have to ALLOW FILTERING here or we must remove the pipelinekey from the table primary key. Given that the eventids will be unique (we generate them in Spark), I don't see an issue with just removing the pipelinekey here.

@c-w c-w requested a review from erikschlegel August 15, 2017 22:52
Copy link
Copy Markdown
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 2e4a9f8 into master Aug 16, 2017
@c-w c-w deleted the fix-messages-queries branch August 16, 2017 15:51
@c-w c-w removed the in progress label Aug 16, 2017
rachelnicole pushed a commit that referenced this pull request Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants