Skip to content
This repository has been archived by the owner. It is now read-only.

Fix all shellcheck errors and warnings #13

Merged
merged 20 commits into from Jun 17, 2017
Merged

Fix all shellcheck errors and warnings #13

merged 20 commits into from Jun 17, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jun 17, 2017

This pull request does a few things relating to leveraging static analysis to improve our shell code:

  1. Run the shellcheck linter on all shell files and fix all errors and warnings
  2. Fix two bugs that were uncovered by the linter: cf1cb02 and e23c836
  3. Add CI to run the linter on all future check-ins
@erikschlegel erikschlegel merged commit a6d4bc8 into CatalystCode:master Jun 17, 2017
rachelnicole pushed a commit that referenced this issue Jan 24, 2018
rachelnicole pushed a commit that referenced this issue Jan 24, 2018
Extract shared methods to expose common structure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants