This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Pass AgentVmSize to Cassandra Helm chart#225
Merged
Merged
Conversation
Contributor
Author
|
@xtophs David mentioned that you may want to have a look at this. |
c-w
added a commit
that referenced
this pull request
Nov 15, 2017
This is the default VM size for our Cassandra chart so we should enable users to deploy Fortis to these VMs. More background: #225
erikschlegel
approved these changes
Nov 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I know very little about ARM templates or Helm. I've also not been able to test the change since the Fortis deployment is non-trivial. So please review this change carefully. Please also let me know what would be the best strategy to verify the change.
@dmakogon reported that currently it's impossible to deploy Fortis on many VM sizes because Cassandra is only getting deployed if a very specific VM size is being used. This change should fix this behavior and enable Fortis to be deployed to many VM sizes.
From my understanding, the VM size to which Cassandra is being deployed via Helm is specified via the VmInstanceType Helm value. So this pull request wires through the AgentVmSize selected during the Fortis deployment (given by the parameter agentVmSize in ARM) to the Cassandra Helm chart set up site.