Skip to content
This repository has been archived by the owner. It is now read-only.

Pass AgentVmSize to Cassandra Helm chart #225

Merged
merged 2 commits into from Nov 27, 2017
Merged

Pass AgentVmSize to Cassandra Helm chart #225

merged 2 commits into from Nov 27, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Nov 15, 2017

Disclaimer: I know very little about ARM templates or Helm. I've also not been able to test the change since the Fortis deployment is non-trivial. So please review this change carefully. Please also let me know what would be the best strategy to verify the change.

@dmakogon reported that currently it's impossible to deploy Fortis on many VM sizes because Cassandra is only getting deployed if a very specific VM size is being used. This change should fix this behavior and enable Fortis to be deployed to many VM sizes.

From my understanding, the VM size to which Cassandra is being deployed via Helm is specified via the VmInstanceType Helm value. So this pull request wires through the AgentVmSize selected during the Fortis deployment (given by the parameter agentVmSize in ARM) to the Cassandra Helm chart set up site.

@c-w c-w requested a review from NathanielRose Nov 15, 2017
@c-w
Copy link
Contributor Author

@c-w c-w commented Nov 15, 2017

@xtophs David mentioned that you may want to have a look at this.

Loading

c-w added a commit that referenced this issue Nov 15, 2017
This is the default VM size for our Cassandra chart so we should enable
users to deploy Fortis to these VMs.

More background:
#225
@c-w c-w mentioned this pull request Nov 15, 2017
c-w added a commit that referenced this issue Nov 16, 2017
More background:
#225
@c-w c-w merged commit 4c655da into master Nov 27, 2017
2 checks passed
Loading
@c-w c-w deleted the pass-vm-size branch Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants