This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Add setup script for FeatureService DB #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjimenez
approved these changes
Jun 30, 2017
ops/install-feature-service-db.sh
Outdated
| if ! (command -v jq >/dev/null); then sudo apt-get install -y jq; fi | ||
| if ! (command -v psql >/dev/null); then sudo apt-get install -y postgresql postgresql-contrib; fi | ||
|
|
||
| echo "!!!! Postgres password for ${pg_admin} set to '${pg_password}' !!!!" |
There was a problem hiding this comment.
Should we remove this echo statement in case this ends up in an unprotected log file?
There was a problem hiding this comment.
I think we need a way to communicate the password to the user in case they wish to connect to their DB and unfortunately the Azure UI does not expose the password. The alternative would be to ask the user to provide a password but that will likely lead to weak passwords. Thoughts?
There was a problem hiding this comment.
I'd just generate a password guid in the deployment script which we'd propagate in the kubernetes ConfigMap
There was a problem hiding this comment.
Moved the password to deis in fce2a39.
jcjimenez
reviewed
Jun 30, 2017
| readonly location="$1" | ||
| readonly resource_group="$2" | ||
|
|
||
| readonly pg_dump="https://fortiscentral.blob.core.windows.net/locations/feature-service.v1.sql.gz" |
c-w
force-pushed
the
install-feature-service-db
branch
2 times, most recently
from
e9ab6da
to
1412bd6
Compare
This avoids potential issues with long-running pipes and http connections.
Instead, set it in the deis config.
c-w
force-pushed
the
install-feature-service-db
branch
from
1412bd6
to
31b2b83
Compare
rachelnicole
pushed a commit
that referenced
this pull request
Jan 24, 2018
Implement EdgesSchema.{terms,locations}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a script that sets up a copy of the feature-service database as part of the deployment. First, we create an Azure-hosted Postgres instance. Then we populate the database from a dump of Tim's master database that is hosted on our central Fortis Azure Blob Storage.
To test the script, you need to change the
pg_dumpvariable to the test database dump as I haven't written the script to dump the master database yet.This is the first required piece to implementing project-fortis#39. The next steps will include writing the script to dump the master database and setting up the featureService repository via deis.