Skip to content
This repository has been archived by the owner. It is now read-only.

Make DROP statements consistent #89

Merged
merged 2 commits into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Jul 21, 2017

No functional change.

@c-w c-w requested a review from jcjimenez Jul 21, 2017

@c-w c-w added the in progress label Jul 21, 2017

@jcjimenez
Copy link
Contributor

left a comment

I propose we move the CREATE statements instead of the DROP ones, what do you think?

@@ -57,8 +57,6 @@ CREATE TABLE trustedsources (
PRIMARY KEY (pipelinekey, externalsourceid, sourcetype, rank)
);

DROP TABLE IF EXISTS events;
DROP TYPE IF EXISTS features;

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Jul 21, 2017

Contributor

These drop statements need to be here. If you put them next to their CREATE TABLE counterparts, the DROP TABLE of their referencing table(s) will fail. For instance, the DROP TABLE features will fail if we don't re-arrange the order in which it's dependency tables are added.

Having said that, I agree that having three seemingly-random DROP TABLE statements together looks weird. Can I suggest we move the CREATE TABLE AND CREATE TYPE statements instead?

This comment has been minimized.

Copy link
@c-w

c-w Jul 21, 2017

Author Member

Good catch, moved everything together in f9c7fdc. Ran it against cqlsh and seems to work.

@erikschlegel
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit 207d57c into master Jul 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the cleanup branch Jul 21, 2017

@c-w c-w removed the in progress label Jul 21, 2017

rachelnicole pushed a commit that referenced this pull request Jan 24, 2018

Merge pull request #89 from CatalystCode/kevinhartman-patch-2
Delete CassandraEventsSink.scala.orig

rachelnicole pushed a commit that referenced this pull request Jan 24, 2018

Fixed admin location editor (#89)
* Fixing a bug related to selected topic and timeseries

* Drawing blue Bounding Box around Selected Place

* Fixing targeted place issue

* Added trusted sources search control

* modified service name

* Fixed a variety of various bugs and highlighting detected place(s)

* Fixing feature selection bug

* Fixing stream filter issues

* Add category filter to dashboard site

* Add category filter to dashboard site

* Add category filter to dashboard site

* Add category filter to dashboard site

* Adding source display name parser

* Final round of unit testing changes for a variety of bug fixes

* Final round of unit testing changes for a variety of bug fixes

* Removing yellow font color

* Fixed admin location editor

* Fixed admin location editor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.