This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Make DROP statements consistent #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjimenez
reviewed
Jul 21, 2017
Contributor
jcjimenez
left a comment
jcjimenez
left a comment
There was a problem hiding this comment.
I propose we move the CREATE statements instead of the DROP ones, what do you think?
| ); | ||
|
|
||
| DROP TABLE IF EXISTS events; | ||
| DROP TYPE IF EXISTS features; |
Contributor
There was a problem hiding this comment.
These drop statements need to be here. If you put them next to their CREATE TABLE counterparts, the DROP TABLE of their referencing table(s) will fail. For instance, the DROP TABLE features will fail if we don't re-arrange the order in which it's dependency tables are added.
Having said that, I agree that having three seemingly-random DROP TABLE statements together looks weird. Can I suggest we move the CREATE TABLE AND CREATE TYPE statements instead?
Contributor
Author
There was a problem hiding this comment.
Good catch, moved everything together in f9c7fdc. Ran it against cqlsh and seems to work.
rachelnicole
pushed a commit
that referenced
this pull request
Jan 24, 2018
Delete CassandraEventsSink.scala.orig
rachelnicole
pushed a commit
that referenced
this pull request
Jan 24, 2018
* Fixing a bug related to selected topic and timeseries * Drawing blue Bounding Box around Selected Place * Fixing targeted place issue * Added trusted sources search control * modified service name * Fixed a variety of various bugs and highlighting detected place(s) * Fixing feature selection bug * Fixing stream filter issues * Add category filter to dashboard site * Add category filter to dashboard site * Add category filter to dashboard site * Add category filter to dashboard site * Adding source display name parser * Final round of unit testing changes for a variety of bug fixes * Final round of unit testing changes for a variety of bug fixes * Removing yellow font color * Fixed admin location editor * Fixed admin location editor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change.