Skip to content
This repository has been archived by the owner. It is now read-only.

Simplify sentiment persistence #90

Merged
merged 1 commit into from Jul 21, 2017
Merged

Simplify sentiment persistence #90

merged 1 commit into from Jul 21, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 21, 2017

The vast majority of services give us a sentiment in the range of
(negative)0 -- 0.6(neutral) -- 1(positive)

So it's much easier for us to store the sentiment value as a single float. Also note that the frontend also requires the sentiment as a single value (there are two values specified in the graphql schema but only one of them is used by the client) which is further evidence that we should only store one value.

Additionally, all sentiments (computedsentiment and avgsentiment) should be the same number type so converting the computedtiles column from int to float.

@c-w c-w requested a review from erikschlegel Jul 21, 2017
Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM

Copy link
Contributor

@erikschlegel erikschlegel left a comment

LGTM

The vast majority of services give us a sentiment in the range of
(negative)0 -- 0.6(neutral) -- 1(positive)

So it's much easier for us to store the sentiment value as a single
float. Also note that the frontend also requires the sentiment as a
single value (there are two values specified in the graphql schema but
only one of them is used by the client) which is further evidence that
we should only store one value.

Additionally, all sentiments (computedsentiment and avgsentiment) should
be the same number type so converting the computedtiles column from int
to float.
@c-w c-w force-pushed the sentiment-simplification branch from 2f3821b to 1d9d542 Jul 21, 2017
@c-w c-w merged commit 44acf03 into master Jul 21, 2017
0 of 2 checks passed
@c-w c-w deleted the sentiment-simplification branch Jul 21, 2017
@c-w c-w removed the in progress label Jul 21, 2017
rachelnicole pushed a commit that referenced this issue Jan 24, 2018
Consistency fixes for settings mutations
rachelnicole pushed a commit that referenced this issue Jan 24, 2018
Added filter against *.orig
rachelnicole pushed a commit that referenced this issue Jan 24, 2018
* Restore sort and filter.

* Add category column, remove flux, bug fixes.

* Add property literals function.

* Add load, save, and remove topics functions.

* Use fragments.

* Remove flux from Admin component.

* Pull out translateSentences into a fragment.

* Add topics fragment.

* Add translatedWordsFragment.

* Add saveTopics and removeTopics fragments.

* Add translateWords query.

* Add getColumns for table.

* Update package.json

* fixing query big
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants