Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Add fulltext column and index to events table#92

Merged
c-w merged 1 commit intomasterfrom
fulltext
Aug 3, 2017
Merged

Add fulltext column and index to events table#92
c-w merged 1 commit intomasterfrom
fulltext

Conversation

@c-w
Copy link
Copy Markdown
Contributor

@c-w c-w commented Jul 28, 2017

The GraphQL schema has a few places where we're required to query by a full text term of an event (e.g. MessagesSchema byBbox). This search should include both the title and the body of the event. However,
Cassandra doesn't support the OR statement so in order to query on both columns at the same time, we need to add a conjunctive version of both columns to our database.

@c-w c-w requested a review from erikschlegel July 28, 2017 20:16
Copy link
Copy Markdown
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The GraphQL schema has a few places where we're required to query by a
full text term of an event (e.g. MessagesSchema byBbox). This search
should include both the title and the body of the event. However,
Cassandra doesn't support the OR statement so in order to query on both
columns at the same time, we need to add a conjunctive version of both
columns to our database.
@c-w c-w merged commit cc9ab17 into master Aug 3, 2017
@c-w c-w deleted the fulltext branch August 3, 2017 21:29
@c-w c-w removed the in progress label Aug 3, 2017
rachelnicole pushed a commit that referenced this pull request Jan 24, 2018
rachelnicole pushed a commit that referenced this pull request Jan 24, 2018
Replace Cognitive Services language detector
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants