Skip to content
This repository has been archived by the owner. It is now read-only.

Fix messages queries with cluster cassandra #100

Merged
merged 2 commits into from Aug 16, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Aug 15, 2017

Pull request relies on this schema change: CatalystCode/project-fortis-pipeline#111

@c-w c-w requested a review from erikschlegel Aug 15, 2017

@c-w c-w added the in progress label Aug 15, 2017

@@ -51,8 +93,8 @@ function byLocation(args, res) { // eslint-disable-line no-unused-vars
AND externalsourceid = ?
AND centroidlat = ?
AND centroidlon = ?
AND eventtime >= ?
AND eventtime <= ?
AND eventime >= ?

This comment has been minimized.

Copy link
@Smarker

Smarker Aug 16, 2017

Contributor

We're not using eventtime anymore?

This comment has been minimized.

Copy link
@c-w

c-w Aug 16, 2017

Author Member

Good catch, I made this change to enable testing against the cluster but it should be reverted.

This comment has been minimized.

Copy link
@c-w

c-w Aug 16, 2017

Author Member

Fixed in f736292.

const originalSentence = args.sentence;

resolve({
translatedSentence,

This comment has been minimized.

Copy link
@Smarker

Smarker Aug 16, 2017

Contributor

You can have an object without properties?

This comment has been minimized.

Copy link
@c-w

c-w Aug 16, 2017

Author Member

This is one of the ES6 niceties:

const foo = 1;
{foo}

Is the same as:

const foo = 1;
{foo: foo}

Only less verbose :)

This comment has been minimized.

Copy link
@Smarker

Smarker Aug 16, 2017

Contributor

Ok good to know!

@Smarker
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit 09f0fe6 into master Aug 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-messages-queries branch Aug 16, 2017

@c-w c-w removed the in progress label Aug 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.