Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Fix messages queries with cluster cassandra #100

Merged
merged 2 commits into from Aug 16, 2017
Merged

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Aug 15, 2017

Pull request relies on this schema change: CatalystCode/project-fortis-pipeline#111

@@ -51,8 +93,8 @@ function byLocation(args, res) { // eslint-disable-line no-unused-vars
AND externalsourceid = ?
AND centroidlat = ?
AND centroidlon = ?
AND eventtime >= ?
AND eventtime <= ?
AND eventime >= ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using eventtime anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I made this change to enable testing against the cluster but it should be reverted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f736292.

const originalSentence = args.sentence;

resolve({
translatedSentence,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have an object without properties?

Copy link
Contributor Author

@c-w c-w Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the ES6 niceties:

const foo = 1;
{foo}

Is the same as:

const foo = 1;
{foo: foo}

Only less verbose :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good to know!

Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 09f0fe6 into master Aug 16, 2017
@c-w c-w deleted the fix-messages-queries branch August 16, 2017 16:02
@c-w c-w removed the in progress label Aug 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants