This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Fix messages queries with cluster cassandra #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smarker
reviewed
Aug 16, 2017
| AND centroidlon = ? | ||
| AND eventtime >= ? | ||
| AND eventtime <= ? | ||
| AND eventime >= ? |
Contributor
There was a problem hiding this comment.
We're not using eventtime anymore?
Contributor
Author
There was a problem hiding this comment.
Good catch, I made this change to enable testing against the cluster but it should be reverted.
| const originalSentence = args.sentence; | ||
|
|
||
| resolve({ | ||
| translatedSentence, |
Contributor
There was a problem hiding this comment.
You can have an object without properties?
Contributor
Author
There was a problem hiding this comment.
This is one of the ES6 niceties:
const foo = 1;
{foo}Is the same as:
const foo = 1;
{foo: foo}Only less verbose :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request relies on this schema change: CatalystCode/project-fortis-pipeline#111