Skip to content
This repository has been archived by the owner. It is now read-only.

Use default appinsights environment variable name #114

Merged
merged 1 commit into from Aug 21, 2017
Merged

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Aug 21, 2017

As per conversation on Slack: we decide to use a single appinsights account for all services so might as well use the same environment variable name everywhere.

@c-w c-w requested a review from erikschlegel Aug 21, 2017
Copy link
Collaborator

@erikschlegel erikschlegel left a comment

LGTM

Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM with question

@@ -18,7 +18,7 @@ TRANSLATION_SERVICE_ACCOUNT_KEY="..."
FACEBOOK_AUTH_TOKEN="..."
FORTIS_FEATURE_SERVICE_HOST="..."
FORTIS_SERVICES_APPINSIGHTS_KEY="..."
APPINSIGHTS_INSTRUMENTATIONKEY="..."
Copy link
Contributor

@jcjimenez jcjimenez Aug 21, 2017

I noticed that in project-fortis-spark the environment variable is APPLICATION_INSIGHTS_IKEY. Do we have a PR for that project as well? Or should we just make this project use that key?

Copy link
Contributor Author

@c-w c-w Aug 21, 2017

This is amazing. The AppInsights SDKs are inconsistent between each other. Java uses APPLICATION_INSIGHTS_IKEY and all the others use APPINSIGHTS_INSTRUMENTATIONKEY. The latter is recommended, so I think we can stick with that.

@c-w c-w merged commit fba2222 into master Aug 21, 2017
2 checks passed
@c-w c-w deleted the appinsights-env-var branch Aug 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants