Skip to content
This repository has been archived by the owner. It is now read-only.

Implement {save,remove}Locations resolver #13

Merged
merged 2 commits into from Jun 29, 2017
Merged

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jun 28, 2017

As mentioned in project-fortis-spark#17, we no longer need these endpoints as the functionality is now handled directly by Spark.

@c-w c-w force-pushed the save-remove-locations-resolver branch 2 times, most recently from 64f0b91 to 94d4003 Jun 29, 2017
@c-w c-w requested a review from Smarker Jun 29, 2017
@c-w c-w force-pushed the save-remove-locations-resolver branch from 94d4003 to 3e57727 Jun 29, 2017
Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM with minor question.

Loading

'We now automatically filter events down to only those ' +
'locations defined in the geo-fence for your site'
);
});
Copy link
Contributor

@jcjimenez jcjimenez Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep these just for backwards compatibility?

Loading

Copy link
Contributor

@Smarker Smarker Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering that as well. Also, does saveLocations in /resolvers need to be changed, too?

Loading

Copy link
Contributor Author

@c-w c-w Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the idea is to have the cassandra-based resolvers to be 100% backwards compatible with the Fortis-v1 UI. This has the advantage that once all of our Fortis-v2 backend work is done, we can just hook up the v2 backend to the v1 frontend for a first milestone and then focus on revamping the frontend as a second milestone without having to worry about an in-flux backend.

The methods in /resolvers don't have to be changed as those are the Fortis-v1 implementations which we're not touching. The GraphQL+Cassandra work is entirely localized to Fortis-v2.

Loading

@c-w c-w merged commit 410bd8a into master Jun 29, 2017
2 checks passed
Loading
@c-w c-w deleted the save-remove-locations-resolver branch Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants