Skip to content
This repository has been archived by the owner. It is now read-only.

Implement {save,remove}Locations resolver #13

Merged
merged 2 commits into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Jun 28, 2017

As mentioned in project-fortis-spark#17, we no longer need these endpoints as the functionality is now handled directly by Spark.

@c-w c-w force-pushed the save-remove-locations-resolver branch 2 times, most recently from 64f0b91 to 94d4003 Jun 28, 2017

@c-w c-w requested a review from Smarker Jun 29, 2017

@c-w c-w force-pushed the save-remove-locations-resolver branch from 94d4003 to 3e57727 Jun 29, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM with minor question.

'We now automatically filter events down to only those ' +
'locations defined in the geo-fence for your site'
);
});

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Jun 29, 2017

Contributor

Do we need to keep these just for backwards compatibility?

This comment has been minimized.

Copy link
@Smarker

Smarker Jun 29, 2017

Contributor

I was wondering that as well. Also, does saveLocations in /resolvers need to be changed, too?

This comment has been minimized.

Copy link
@c-w

c-w Jun 29, 2017

Author Member

Yes, the idea is to have the cassandra-based resolvers to be 100% backwards compatible with the Fortis-v1 UI. This has the advantage that once all of our Fortis-v2 backend work is done, we can just hook up the v2 backend to the v1 frontend for a first milestone and then focus on revamping the frontend as a second milestone without having to worry about an in-flux backend.

The methods in /resolvers don't have to be changed as those are the Fortis-v1 implementations which we're not touching. The GraphQL+Cassandra work is entirely localized to Fortis-v2.

@c-w c-w merged commit 410bd8a into master Jun 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the save-remove-locations-resolver branch Jun 29, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.