Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Implement {save,remove}Locations resolver #13

Merged
merged 2 commits into from Jun 29, 2017
Merged

Implement {save,remove}Locations resolver #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc27a0c
Implement {save,remove}Locations resolver
c-w Jun 28, 2017
3e57727
Provide feedback to user about API call
c-w Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/resolvers-cassandra/Edges.js
View file
Open in desktop
@@ -1,7 +1,7 @@
'use strict';

module.exports = {
// ---------------------------------------------------------------------------------- mutations
// ---------------------------------------------------------------------------------- mutations

removeKeywords(args, res){ // eslint-disable-line no-unused-vars
},
Expand All @@ -10,12 +10,26 @@ module.exports = {
},

saveLocations(args, res){ // eslint-disable-line no-unused-vars
return new Promise((resolve, reject) => { // eslint-disable-line no-unused-vars
reject(
'This API call is no longer supported. ' +
'We now automatically filter events down to only those ' +
'locations defined in the geo-fence for your site'
);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep these just for backwards compatibility?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering that as well. Also, does saveLocations in /resolvers need to be changed, too?

Copy link
Contributor Author

@c-w c-w Jun 29, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the idea is to have the cassandra-based resolvers to be 100% backwards compatible with the Fortis-v1 UI. This has the advantage that once all of our Fortis-v2 backend work is done, we can just hook up the v2 backend to the v1 frontend for a first milestone and then focus on revamping the frontend as a second milestone without having to worry about an in-flux backend.

The methods in /resolvers don't have to be changed as those are the Fortis-v1 implementations which we're not touching. The GraphQL+Cassandra work is entirely localized to Fortis-v2.

},

removeLocations(args, res){ // eslint-disable-line no-unused-vars
return new Promise((resolve, reject) => { // eslint-disable-line no-unused-vars
reject(
'This API call is no longer supported. ' +
'We now automatically filter events down to only those ' +
'locations defined in the geo-fence for your site'
);
});
},

// ------------------------------------------------------------------------------------ queries
// ------------------------------------------------------------------------------------ queries

terms(args, res){ // eslint-disable-line no-unused-vars
},
Expand Down