Skip to content
This repository has been archived by the owner. It is now read-only.

Fix create_site.py failing #166

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Oct 31, 2017

The createSite call was failing with an error of "Unmatched column names/values". This is due to a regression introduced in 872e1ae which added a param to the fortis.watchlist insertion cassandra query without adding a placeholder in the query CQL.

Additionally, the topic category is required to always be non-null so we default it to an empty string if the category is not set in the blob watchlist terms.

Tagging @erikschlegel since he requested the fix.

Here is the createSite mutation succeeding after the fix:

image

Here is the create_site.py script succeeding after the fix:

image

Fix create_site.py failing
The create-site call was failing with an error of "Unmatched column
names/values". This is due to a regression introduced in 872e1ae which
added a param to the fortis.watchlist insertion call without adding a
placeholder in the CQL.

Additionally, the topic category is required to always be non-null so we
default it to an empty string if the category is not set in the blob
watchlist terms.

@c-w c-w requested a review from Smarker Oct 31, 2017

@Smarker
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit 62486a6 into master Oct 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-create-site-failure branch Oct 31, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.