This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Fix create_site.py failing - #166
Merged
Merged
Conversation
The create-site call was failing with an error of "Unmatched column names/values". This is due to a regression introduced in 872e1ae which added a param to the fortis.watchlist insertion call without adding a placeholder in the CQL. Additionally, the topic category is required to always be non-null so we default it to an empty string if the category is not set in the blob watchlist terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The createSite call was failing with an error of "Unmatched column names/values". This is due to a regression introduced in 872e1ae which added a param to the fortis.watchlist insertion cassandra query without adding a placeholder in the query CQL.
Additionally, the topic category is required to always be non-null so we default it to an empty string if the category is not set in the blob watchlist terms.
Tagging @erikschlegel since he requested the fix.
Here is the createSite mutation succeeding after the fix:
Here is the create_site.py script succeeding after the fix: