Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Fix create_site.py failing #166

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Fix create_site.py failing #166

merged 1 commit into from
Oct 31, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Oct 31, 2017

The createSite call was failing with an error of "Unmatched column names/values". This is due to a regression introduced in 872e1ae which added a param to the fortis.watchlist insertion cassandra query without adding a placeholder in the query CQL.

Additionally, the topic category is required to always be non-null so we default it to an empty string if the category is not set in the blob watchlist terms.

Tagging @erikschlegel since he requested the fix.

Here is the createSite mutation succeeding after the fix:

image

Here is the create_site.py script succeeding after the fix:

image

The create-site call was failing with an error of "Unmatched column
names/values". This is due to a regression introduced in 872e1ae which
added a param to the fortis.watchlist insertion call without adding a
placeholder in the CQL.

Additionally, the topic category is required to always be non-null so we
default it to an empty string if the category is not set in the blob
watchlist terms.
@c-w c-w requested a review from Smarker October 31, 2017 00:54
Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 62486a6 into master Oct 31, 2017
@c-w c-w deleted the fix-create-site-failure branch October 31, 2017 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants