Skip to content
This repository has been archived by the owner. It is now read-only.

Dockerize #167

Merged
merged 6 commits into from Nov 28, 2017
Merged

Dockerize #167

merged 6 commits into from Nov 28, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Nov 28, 2017

See CatalystCode/project-fortis-pipeline#228

This also resolves #164 since the readme update points users directly to the GraphiQL test consoles; from there, everything in GraphQL should be self-documenting.

Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM!

@@ -0,0 +1,33 @@
#!/usr/bin/env sh
Copy link
Contributor

@jcjimenez jcjimenez Nov 28, 2017

Any chance you can add a set -e so that it exists on first failure?

#!/usr/bin/env sh
set -e

Copy link
Contributor Author

@c-w c-w Nov 28, 2017

Great comment. I'm usually the first one to advocate for Bash strict mode (set -euo pipefail). However, some of the commands below are expected to fail (e.g. when waiting for Cassandra to come up) so I think it's cleaner to not enable strict-mode here since otherwise we'd have to sprinkle a bunch of || true across the code which may confuse folks with less Bash experience.

# set up cassandra schema
if [ -n "$FORTIS_CASSANDRA_SCHEMA_URL" ]; then
echo "Got Fortis schema definition at $FORTIS_CASSANDRA_SCHEMA_URL, ingesting..."
wget -qO- "$FORTIS_CASSANDRA_SCHEMA_URL" | cassandra_exec
Copy link
Contributor

@jcjimenez jcjimenez Nov 28, 2017

Excellent! At some point, I think we could move these DDL statements into database migrations running on this project (fortis-services).

@c-w c-w merged commit 3df5a2d into master Nov 28, 2017
3 checks passed
@c-w c-w deleted the dockerize branch Nov 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants