Skip to content
This repository has been archived by the owner. It is now read-only.

Dockerize #167

Merged
merged 6 commits into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Nov 28, 2017

See CatalystCode/project-fortis-pipeline#228

This also resolves #164 since the readme update points users directly to the GraphiQL test consoles; from there, everything in GraphQL should be self-documenting.

@c-w c-w referenced this pull request Nov 28, 2017

Closed

Improve developer experience #228

@c-w c-w requested a review from jcjimenez Nov 28, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM!

@@ -0,0 +1,33 @@
#!/usr/bin/env sh

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Nov 28, 2017

Contributor

Any chance you can add a set -e so that it exists on first failure?

#!/usr/bin/env sh
set -e

This comment has been minimized.

Copy link
@c-w

c-w Nov 28, 2017

Author Member

Great comment. I'm usually the first one to advocate for Bash strict mode (set -euo pipefail). However, some of the commands below are expected to fail (e.g. when waiting for Cassandra to come up) so I think it's cleaner to not enable strict-mode here since otherwise we'd have to sprinkle a bunch of || true across the code which may confuse folks with less Bash experience.

# set up cassandra schema
if [ -n "$FORTIS_CASSANDRA_SCHEMA_URL" ]; then
echo "Got Fortis schema definition at $FORTIS_CASSANDRA_SCHEMA_URL, ingesting..."
wget -qO- "$FORTIS_CASSANDRA_SCHEMA_URL" | cassandra_exec

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Nov 28, 2017

Contributor

Excellent! At some point, I think we could move these DDL statements into database migrations running on this project (fortis-services).

@c-w c-w merged commit 3df5a2d into master Nov 28, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details

@c-w c-w deleted the dockerize branch Nov 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.