Skip to content
This repository has been archived by the owner. It is now read-only.

Implement Facebook page update time fetching #19

Merged
merged 1 commit into from Jun 29, 2017
Merged

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jun 29, 2017

As per the comment on project-fortis#49, this pull request implements the page-last-updated-at functionality of the FacebookAnalytics resolver.

Sample graphiql request and response:

image

To finish the implementation of the FacebookAnalytics resolver, we just need to fetch the Facebook pageIds for the requesting site from Cassandra. This is blocked on the Cassandra connector work by @Smarker so using a hard-coded list for now.

Similarly, tests will be implemented after @Smarker merges her example test setup.

@c-w c-w requested a review from jcjimenez Jun 29, 2017
Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM

@c-w c-w merged commit 57f6cd8 into master Jun 29, 2017
2 checks passed
@c-w c-w deleted the facebookanalytics-resolver branch Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants