Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jun 29, 2017

After merging this pull request, the eslint step in our CI pipeline will fail if there is any require call against a dependency that doesn't exist.

For example, this will protect us against the following types of problems:

const Promise = require('promse');
const eventHubSender = require('../eventhubClient/EventHubSemder');

Sample build that detected a bad import: Job#94.1.

@c-w c-w requested a review from Smarker June 29, 2017 17:55
@c-w c-w force-pushed the require-linting branch from 5845638 to 3b03a9a Compare June 29, 2017 20:25
Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 5dcd510 into master Jun 29, 2017
@c-w c-w deleted the require-linting branch June 29, 2017 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants