This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce clients package #21
Conversation
c-w
requested a review
from jcjimenez
Jun 29, 2017
c-w
requested a review
from Smarker
Jun 29, 2017
c-w
merged commit 384ca14
into
master
Jun 29, 2017
c-w
deleted the
clients-refactor
branch
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
c-w commentedJun 29, 2017
This pull request improves the organization of our package structure by introducing a wrapper package for all clients. After merging, our folder structure will be much simpler:
schemasandresolversfor GraphQL plusclientsfor third-party integrations.While looking at all of our
requirestatements, I also fixed a few inconsistencies like always usingconstand never relying on an implicitPromiseobject.