Skip to content
This repository has been archived by the owner. It is now read-only.

Implement client for feature service #22

Merged
merged 2 commits into from Jun 30, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Jun 29, 2017

This will be required for a few of the GraphQL resolvers, e.g. MessageSchema.byBbox, TilesSchema.fetchPlacesByBbox and EdgesSchema.locations.

Should be merged after #21.

@c-w c-w requested a review from jcjimenez Jun 29, 2017

@c-w c-w force-pushed the featureservice branch from bc0aff1 to 5abf3e5 Jun 29, 2017

@c-w c-w changed the base branch from clients-refactor to master Jun 29, 2017

@Smarker
Copy link
Contributor

left a comment

LGTM but maybe you'd want to put modules.export at the top so that we can easily see all the functions we have available to us?

@jcjimenez
Copy link
Contributor

left a comment

LGTM with question.

}

function formatNameUri(names) {
return `http://${apiHost}/features/name/${names.join(',')}`;

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Jun 30, 2017

Contributor

Do we need to URL escape all these values?

This comment has been minimized.

Copy link
@c-w

c-w Jun 30, 2017

Author Member

Done in c381784.

@c-w

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2017

@Smarker Always declaring the exports at the bottom of the file also makes it easy to find them and has the benefit that it always works, even for exports that are declared as variables instead of functions (read more).

@Smarker

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2017

Alright, good point. I agree.

@c-w c-w merged commit 6c7916f into master Jun 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the featureservice branch Jun 30, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.