Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Implement client for feature service #22

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Implement client for feature service #22

merged 2 commits into from
Jun 30, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jun 29, 2017

This will be required for a few of the GraphQL resolvers, e.g. MessageSchema.byBbox, TilesSchema.fetchPlacesByBbox and EdgesSchema.locations.

Should be merged after #21.

@c-w c-w requested a review from jcjimenez June 29, 2017 18:30
@c-w c-w changed the base branch from clients-refactor to master June 29, 2017 20:25
Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe you'd want to put modules.export at the top so that we can easily see all the functions we have available to us?

Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with question.

}

function formatNameUri(names) {
return `http://${apiHost}/features/name/${names.join(',')}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to URL escape all these values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in c381784.

@c-w
Copy link
Contributor Author

c-w commented Jun 30, 2017

@Smarker Always declaring the exports at the bottom of the file also makes it easy to find them and has the benefit that it always works, even for exports that are declared as variables instead of functions (read more).

@Smarker
Copy link
Contributor

Smarker commented Jun 30, 2017

Alright, good point. I agree.

@c-w c-w merged commit 6c7916f into master Jun 30, 2017
@c-w c-w deleted the featureservice branch June 30, 2017 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants