Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Consistency fixes #30

Merged
merged 3 commits into from Jul 3, 2017
Merged

Consistency fixes #30

merged 3 commits into from Jul 3, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 3, 2017

  1. Always use catch(reject) for simple promise error handling.
  2. Whitespace fixes
  3. When rejecting a promise, inline the return.

No functional change.

@c-w c-w requested a review from Smarker July 3, 2017 18:09
Smarker
Smarker approved these changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit ba47433 into master Jul 3, 2017
@c-w c-w deleted the consistency-fixes branch July 3, 2017 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Smarker Smarker Smarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c-w @Smarker