Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Implement MessageSchema.{byBbox,byLocation,byEdges} resolver #31

Merged
merged 16 commits into from
Jul 5, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 3, 2017

@c-w c-w changed the title Implement MessageSchema.byBbox resolver Implement MessageSchema.{byBbox,byLocation,byEdges} resolver Jul 3, 2017
@c-w c-w requested a review from erikschlegel July 3, 2017 19:11
Copy link
Collaborator

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const clauses = defaults.clauses;
let params = defaults.params;

clauses.push(`(${placeIds.map(_ => '(detectedplaceids CONTAINS ?)').join(' OR ')})`); // eslint-disable-line no-unused-vars
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add some validation to ensure that detectedplaceids are all numbers

@c-w c-w merged commit 919a4ae into master Jul 5, 2017
@c-w c-w deleted the messages-resolver branch July 5, 2017 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants