Skip to content
This repository has been archived by the owner. It is now read-only.

Implement FactSchema.{list,get} #32

Merged
merged 3 commits into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jul 3, 2017

@c-w c-w force-pushed the facts-resolver branch from 7392219 to 1b9473c Jul 3, 2017

@c-w c-w requested a review from erikschlegel Jul 3, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM with minor question.

const facts = rows.map(cassandraRowToFact);

resolve({
facts: facts

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Jul 3, 2017

Contributor

Where's my runTime at? =)

This comment has been minimized.

Copy link
@c-w

c-w Jul 3, 2017

Author Member

This is a cross-cutting concern that we should implement once for all the resolvers (e.g. as a decorator).

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Jul 3, 2017

Contributor

Agreed!

@c-w c-w force-pushed the facts-resolver branch from 1b9473c to a6d78fd Jul 3, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit c2db278 into master Jul 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the facts-resolver branch Jul 6, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.