Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Implement FactSchema.{list,get} #32

Merged
merged 3 commits into from
Jul 6, 2017
Merged

Implement FactSchema.{list,get} #32

merged 3 commits into from
Jul 6, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 3, 2017

Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor question.

const facts = rows.map(cassandraRowToFact);

resolve({
facts: facts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's my runTime at? =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cross-cutting concern that we should implement once for all the resolvers (e.g. as a decorator).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit c2db278 into master Jul 6, 2017
@c-w c-w deleted the facts-resolver branch July 6, 2017 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants