Skip to content
This repository has been archived by the owner. It is now read-only.

Implement FactSchema.{list,get} #32

Merged
merged 3 commits into from Jul 6, 2017
Merged

Implement FactSchema.{list,get} #32

merged 3 commits into from Jul 6, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 3, 2017

project-fortis#51

@c-w c-w force-pushed the facts-resolver branch from 7392219 to 1b9473c Jul 3, 2017
@c-w c-w requested a review from erikschlegel Jul 3, 2017
Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM with minor question.

const facts = rows.map(cassandraRowToFact);

resolve({
facts: facts
Copy link
Contributor

@jcjimenez jcjimenez Jul 3, 2017

Where's my runTime at? =)

Copy link
Contributor Author

@c-w c-w Jul 3, 2017

This is a cross-cutting concern that we should implement once for all the resolvers (e.g. as a decorator).

Copy link
Contributor

@jcjimenez jcjimenez Jul 3, 2017

Agreed!

@c-w c-w force-pushed the facts-resolver branch from 1b9473c to a6d78fd Jul 3, 2017
Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM

@c-w c-w merged commit c2db278 into master Jul 6, 2017
2 checks passed
@c-w c-w deleted the facts-resolver branch Jul 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants