This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Implement SettingsSchema.sites. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jcjimenez
commented
Jul 3, 2017
•
jcjimenez
commented
Smarker
approved these changes
Jul 3, 2017
| return reject(`Could not find site with id ${siteId}`); | ||
| } | ||
| if (rows.length > 1) { | ||
| return reject(`Got more than one (${rows.length}) site with id ${siteId}`); |
There was a problem hiding this comment.
This reject's statement might get confusing (suppose rows.length is 3 and siteId is 1):
Got more than one 3 site with id 1
There was a problem hiding this comment.
Good, point! But I think we should be safe since it will look more like this:
Got more than one (2) site with id d4d294ec-5b2c-4674-8f3f-e1eb7b8dbb47
There was a problem hiding this comment.
But I agree - let me work on making that more readable.
There was a problem hiding this comment.
Oh yea you are right! Didn't see the parentheses.
| const siteCollection = Object.assign({}, {runTime: '' + (Date.now() - startTime), sites: [ site ]}); | ||
| resolve(siteCollection); | ||
| }) | ||
| .catch(err => reject(err)) |
There was a problem hiding this comment.
You can also do catch(reject); here.
c-w
approved these changes
Jul 3, 2017
| // .catch(err => reject(err)) | ||
| .then(rows => { | ||
| if (rows.length < 1) { | ||
| return reject(`Could not find site with id ${siteId}`); |
There was a problem hiding this comment.
Nit: could inline the return-reject like elsewhere if (...) return reject(...)
| } | ||
|
|
||
| const site = cassandraRowToSite(rows[0]); | ||
| const siteCollection = Object.assign({}, {runTime: '' + (Date.now() - startTime), sites: [ site ]}); |
There was a problem hiding this comment.
This is implemented more generally in #34.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.