Skip to content
This repository has been archived by the owner. It is now read-only.

Implement TilesSchema.{fetchTilesByLocations,fetchPlacesbyBbox,fetchTilesByBbox} #39

Merged
merged 13 commits into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Jul 4, 2017

@c-w c-w requested a review from erikschlegel Jul 4, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM

@erikschlegel
Copy link
Collaborator

left a comment

This looks great.

@@ -10,7 +10,7 @@ function formatIdsUri(ids) {
}

function formatBboxUri(north, west, south, east) {
return `http://${apiHost}/features/bbox/${north}/${west}/${south}/${east}`;
return `http://${apiHost}/features/bbox/${north}/${west}/${south}/${east}?include=bbox`;

This comment has been minimized.

Copy link
@erikschlegel

erikschlegel Jul 5, 2017

Collaborator

apiHost will contain either http or https

This comment has been minimized.

Copy link
@c-w

c-w Jul 5, 2017

Author Member

Did this as a separate PR that's now merged; see ad39b8b.

const withRunTime = require('../shared').withRunTime;

/**
* @see http://wiki.openstreetmap.org/wiki/Slippy_map_tilenames#Python
*/
function deg2num(lat_deg, lon_deg, zoom) {

This comment has been minimized.

Copy link
@erikschlegel

erikschlegel Jul 5, 2017

Collaborator

I believe this same functionality is already available in Tile.tileIdFromLatLong within the geotile module

This comment has been minimized.

Copy link
@c-w

c-w Jul 5, 2017

Author Member

Cool. Switched to that implementation in e6b737a 6fd3c13 36be473.

@c-w c-w force-pushed the tiles-resolver branch from e6b737a to 6fd3c13 Jul 5, 2017

@c-w c-w force-pushed the tiles-resolver branch from 6fd3c13 to 36be473 Jul 5, 2017

@c-w c-w merged commit f4566be into master Jul 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the tiles-resolver branch Jul 5, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.