-
Notifications
You must be signed in to change notification settings - Fork 5
Implement TilesSchema.{fetchTilesByLocations,fetchPlacesbyBbox,fetchTilesByBbox} #39
Conversation
jcjimenez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
erikschlegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
|
|
||
| function formatBboxUri(north, west, south, east) { | ||
| return `http://${apiHost}/features/bbox/${north}/${west}/${south}/${east}`; | ||
| return `http://${apiHost}/features/bbox/${north}/${west}/${south}/${east}?include=bbox`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiHost will contain either http or https
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this as a separate PR that's now merged; see ad39b8b.
| /** | ||
| * @see http://wiki.openstreetmap.org/wiki/Slippy_map_tilenames#Python | ||
| */ | ||
| function deg2num(lat_deg, lon_deg, zoom) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this same functionality is already available in Tile.tileIdFromLatLong within the geotile module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project-fortis#52