Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Implement TilesSchema.{fetchTilesByLocations,fetchPlacesbyBbox,fetchTilesByBbox} #39

Merged
merged 13 commits into from
Jul 5, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 4, 2017

@c-w c-w requested a review from erikschlegel July 4, 2017 19:40
Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@@ -10,7 +10,7 @@ function formatIdsUri(ids) {
}

function formatBboxUri(north, west, south, east) {
return `http://${apiHost}/features/bbox/${north}/${west}/${south}/${east}`;
return `http://${apiHost}/features/bbox/${north}/${west}/${south}/${east}?include=bbox`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiHost will contain either http or https

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this as a separate PR that's now merged; see ad39b8b.

const withRunTime = require('../shared').withRunTime;

/**
* @see http://wiki.openstreetmap.org/wiki/Slippy_map_tilenames#Python
*/
function deg2num(lat_deg, lon_deg, zoom) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this same functionality is already available in Tile.tileIdFromLatLong within the geotile module

Copy link
Contributor Author

@c-w c-w Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Switched to that implementation in e6b737a 6fd3c13 36be473.

@c-w c-w merged commit f4566be into master Jul 5, 2017
@c-w c-w deleted the tiles-resolver branch July 5, 2017 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants