Skip to content
This repository has been archived by the owner. It is now read-only.

Fix all eslint issues #5

Merged
merged 6 commits into from Jun 21, 2017
Merged

Fix all eslint issues #5

merged 6 commits into from Jun 21, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jun 20, 2017

This pull request fixes all eslint issues and sets up CI so that we always run tests and lint on every check-in/pull-request.

The pull request also fixes a few bugs uncovered by eslint, mostly to do with referencing undefined variables.

@c-w c-w requested review from erikschlegel and Smarker Jun 20, 2017
Copy link
Contributor

@Smarker Smarker left a comment

Looks good. I see that I will have to make changes in my code since I might have used double quotes a couple of times rather than single quotes.

node_js

node_js:
- "7"
Copy link
Contributor

@Smarker Smarker Jun 20, 2017

package.json has node version 6.0.0 not sure if we want to keep our version at 7 or change what is in .travis.yml from 7 to 6.

Copy link
Contributor Author

@c-w c-w Jun 20, 2017

Good catch. We can run on both actually, see 0aa6524.

Copy link
Contributor Author

@c-w c-w Jun 20, 2017

NB: you can use ./node_modules/.bin/eslint src --fix to auto-fix simple issues like double-quotes vs single-quotes.

Copy link
Collaborator

@erikschlegel erikschlegel left a comment

Thank you!

@erikschlegel erikschlegel merged commit c057760 into master Jun 21, 2017
2 checks passed
@c-w c-w deleted the fix-eslint branch Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants