Skip to content
This repository has been archived by the owner. It is now read-only.

Fix all eslint issues #5

Merged
merged 6 commits into from Jun 21, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Jun 20, 2017

This pull request fixes all eslint issues and sets up CI so that we always run tests and lint on every check-in/pull-request.

The pull request also fixes a few bugs uncovered by eslint, mostly to do with referencing undefined variables.

@c-w c-w requested review from erikschlegel and Smarker Jun 20, 2017

@Smarker
Copy link
Contributor

left a comment

Looks good. I see that I will have to make changes in my code since I might have used double quotes a couple of times rather than single quotes.

node_js

node_js:
- "7"

This comment has been minimized.

Copy link
@Smarker

Smarker Jun 20, 2017

Contributor

package.json has node version 6.0.0 not sure if we want to keep our version at 7 or change what is in .travis.yml from 7 to 6.

This comment has been minimized.

Copy link
@c-w

c-w Jun 20, 2017

Author Member

Good catch. We can run on both actually, see 0aa6524.

This comment has been minimized.

Copy link
@c-w

c-w Jun 20, 2017

Author Member

NB: you can use ./node_modules/.bin/eslint src --fix to auto-fix simple issues like double-quotes vs single-quotes.

@erikschlegel
Copy link
Collaborator

left a comment

Thank you!

@erikschlegel erikschlegel merged commit c057760 into master Jun 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-eslint branch Jun 21, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.