This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Fix all eslint issues #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smarker
approved these changes
Jun 20, 2017
Contributor
Smarker
left a comment
Smarker
left a comment
There was a problem hiding this comment.
Looks good. I see that I will have to make changes in my code since I might have used double quotes a couple of times rather than single quotes.
| node_js | ||
|
|
||
| node_js: | ||
| - "7" |
Contributor
There was a problem hiding this comment.
package.json has node version 6.0.0 not sure if we want to keep our version at 7 or change what is in .travis.yml from 7 to 6.
Contributor
Author
There was a problem hiding this comment.
Good catch. We can run on both actually, see 0aa6524.
Contributor
Author
There was a problem hiding this comment.
NB: you can use ./node_modules/.bin/eslint src --fix to auto-fix simple issues like double-quotes vs single-quotes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes all eslint issues and sets up CI so that we always run tests and lint on every check-in/pull-request.
The pull request also fixes a few bugs uncovered by eslint, mostly to do with referencing undefined variables.