This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Integrate with application insights #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smarker
approved these changes
Jul 6, 2017
| .then(returnValue => { | ||
| const duration = new Date() - start; | ||
| const success = true; | ||
| client.trackEvent(eventName, { duration: duration, success: success }); |
Contributor
There was a problem hiding this comment.
What if you wanted to add other properties to the event like siteType? Or metrics like the number of inserts performed? Would it be more flexible to add a third optional parameter to trackEvent for properties and a fourth optional parameter to it for metrics?
Contributor
Author
| appInsights.setup(appInsightsKey); | ||
| appInsights.start(); | ||
| client = appInsights.getClient(appInsightsKey); | ||
| console.log = trackTrace(/* INFO */ 1, consoleLog); |
Contributor
There was a problem hiding this comment.
Would enumerating the values 1, 2, 3 as INFO, ERROR, WARNING be more clear?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make use of three application insights apis:
trackTracefor log statementstrackDependencyfor call to third-party servicestrackEventfor first-party scenarios