Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

A few CQL fixes#61

Merged
c-w merged 2 commits intomasterfrom
fix-cql
Jul 7, 2017
Merged

A few CQL fixes#61
c-w merged 2 commits intomasterfrom
fix-cql

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 7, 2017

  1. CQL does not have a general-purpose OR so replacing with IN where possible.
  2. String literals need to be escaped with ', not "

Smarker
Smarker approved these changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jcjimenez
jcjimenez approved these changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 16b51b0 into master Jul 7, 2017
@c-w c-w deleted the fix-cql branch July 7, 2017 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jcjimenez jcjimenez jcjimenez approved these changes

@Smarker Smarker Smarker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-w @jcjimenez @Smarker