This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Remove data that's never passed from the client#79
Merged
Conversation
See https://github.com/CatalystCode/project-fortis-interfaces/search?q=%2Fapi%2Ffacts: the facts endpoint is never used by the client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@erikschlegel: As we talked about, there is a bunch of data that is included in our GraphQL schema but that's never passed from the client to the server. I've removed all such data that I could find via visual inspection of the project-fortis-interfaces project so that our query requirements are made clearer.