Skip to content
This repository has been archived by the owner. It is now read-only.

Correctly implement sourceFilter #81

Merged
merged 2 commits into from Jul 11, 2017
Merged

Correctly implement sourceFilter #81

merged 2 commits into from Jul 11, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 11, 2017

No sources passed means "select from all sources", not "select no sources". See client code for reference.

Copy link
Contributor

@jcjimenez jcjimenez left a comment

LGTM - I have a similar PR about this.

@c-w c-w merged commit 4846f58 into master Jul 11, 2017
2 checks passed
@c-w c-w deleted the sourcefilter branch Jul 11, 2017
@c-w c-w removed the in progress label Jul 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants