Skip to content
This repository has been archived by the owner. It is now read-only.

Correctly implement sourceFilter #81

Merged
merged 2 commits into from Jul 11, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jul 11, 2017

No sources passed means "select from all sources", not "select no sources". See client code for reference.

c-w added some commits Jul 11, 2017

Correctly implement sourceFilter
No sources passed means "select from all sources", not "select no
sources". See client code for reference:
https://github.com/CatalystCode/project-fortis-interfaces/blob/cf241d64fec65875682eb0978fcae1d715db6472/src/actions/Actions.js#L278

@c-w c-w added the in progress label Jul 11, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM - I have a similar PR about this.

@c-w c-w merged commit 4846f58 into master Jul 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the sourcefilter branch Jul 11, 2017

@c-w c-w removed the in progress label Jul 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.