Skip to content
This repository has been archived by the owner. It is now read-only.

Extract shared multi-queries code #82

Merged
merged 3 commits into from Jul 12, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jul 11, 2017

No functional change.

@c-w c-w added the in progress label Jul 11, 2017

*/
function executeQueries(queries) {
return new Promise((resolve, reject) => {
Promise.all(queries.map(query => executeQuery(query.query, query.params)))

This comment has been minimized.

Copy link
@Smarker

Smarker Jul 12, 2017

Contributor

What about using asyncEachLimit instead of Promise.all?

This comment has been minimized.

Copy link
@c-w

c-w Jul 12, 2017

Author Member

That'll be a good future enhancement.

This comment has been minimized.

Copy link
@Smarker

Smarker Jul 12, 2017

Contributor

nice ok!

@Smarker
Copy link
Contributor

left a comment

LGTM, and it would be nice to add asyncEachLimit as a future enhancement.

@c-w c-w merged commit 2b6d058 into master Jul 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the multi-queries branch Jul 12, 2017

@c-w c-w removed the in progress label Jul 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.