Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Remove event_time and eventids#92

Merged
c-w merged 1 commit intomasterfrom
remove-eventtime
Aug 10, 2017
Merged

Remove event_time and eventids#92
c-w merged 1 commit intomasterfrom
remove-eventtime

Conversation

@c-w
Copy link
Copy Markdown
Contributor

@c-w c-w commented Aug 8, 2017

@erikschlegel mentioned that we should avoid the eventids collection as the collections hold at most 65k entries and we may have more events for a particular point-in-time and topic/place combination.

Doing the change on the query side first, will do the change in the schema repository once we've agreed on an approach.

@c-w c-w requested a review from erikschlegel August 8, 2017 17:59
@c-w c-w added the in progress label Aug 8, 2017
Copy link
Copy Markdown
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w force-pushed the remove-eventtime branch from 09ab333 to 5e2cd0a Compare August 8, 2017 19:18
c-w added a commit to CatalystCode/project-fortis-pipeline that referenced this pull request Aug 8, 2017
This is the schema change for the following service-side change:
CatalystCode/project-fortis-services#92
@c-w c-w merged commit 9fbe532 into master Aug 10, 2017
@c-w c-w deleted the remove-eventtime branch August 10, 2017 22:40
c-w added a commit to CatalystCode/project-fortis-pipeline that referenced this pull request Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants