Skip to content
This repository has been archived by the owner. It is now read-only.

Remove query on placeid #94

Merged
merged 1 commit into from Aug 14, 2017
Merged

Remove query on placeid #94

merged 1 commit into from Aug 14, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Aug 10, 2017

As per comment
https://github.com/CatalystCode/project-fortis-pipeline/pull/101/files#r132579693

@c-w c-w requested a review from erikschlegel Aug 10, 2017
c-w added a commit to CatalystCode/project-fortis-pipeline that referenced this issue Aug 10, 2017
@c-w c-w mentioned this pull request Aug 10, 2017
Copy link
Contributor

@Smarker Smarker left a comment

LGTM

@@ -49,64 +48,61 @@ function byBbox(args, res) { // eslint-disable-line no-unused-vars
if (!args.bbox || args.bbox.length !== 4) return reject('Invalid bbox specified');

const { fromDate, toDate } = parseFromToDate(args.fromDate, args.toDate);
const limit = args.limit || 15;
Copy link
Contributor

@Smarker Smarker Aug 14, 2017

I'd maybe use a name more specific than limit to make it more clear why it's needed.

@c-w c-w merged commit 6bac34c into master Aug 14, 2017
2 checks passed
@c-w c-w deleted the remove-placeid-query branch Aug 14, 2017
Copy link
Collaborator

@erikschlegel erikschlegel left a comment

Looks good. Just one posted question below.

const [north, west, south, east] = args.bbox;

const tagsQuery = `
SELECT eventid
Copy link
Collaborator

@erikschlegel erikschlegel Aug 14, 2017

would distinct eventid work for this query? Trying to mitigate the duplicate record issue.

Copy link
Contributor Author

@c-w c-w Aug 14, 2017

@erikschlegel How do you propose to address this?

image

Copy link
Collaborator

@erikschlegel erikschlegel Aug 14, 2017

it was more of a question which you just answered.

Copy link
Collaborator

@erikschlegel erikschlegel left a comment

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants