This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Remove query on placeid #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-w
added a commit
to CatalystCode/project-fortis-pipeline
that referenced
this pull request
Aug 10, 2017
This is the schema change for the following service-side changes: CatalystCode/project-fortis-services#92 CatalystCode/project-fortis-services#94
This was referenced Aug 10, 2017
Smarker
approved these changes
Aug 14, 2017
| if (!args.bbox || args.bbox.length !== 4) return reject('Invalid bbox specified'); | ||
|
|
||
| const { fromDate, toDate } = parseFromToDate(args.fromDate, args.toDate); | ||
| const limit = args.limit || 15; |
Contributor
There was a problem hiding this comment.
I'd maybe use a name more specific than limit to make it more clear why it's needed.
Collaborator
erikschlegel
left a comment
erikschlegel
left a comment
There was a problem hiding this comment.
Looks good. Just one posted question below.
| const [north, west, south, east] = args.bbox; | ||
|
|
||
| const tagsQuery = ` | ||
| SELECT eventid |
Collaborator
There was a problem hiding this comment.
would distinct eventid work for this query? Trying to mitigate the duplicate record issue.
Contributor
Author
There was a problem hiding this comment.
@erikschlegel How do you propose to address this?
Collaborator
There was a problem hiding this comment.
it was more of a question which you just answered.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per comment
https://github.com/CatalystCode/project-fortis-pipeline/pull/101/files#r132579693