Skip to content
This repository has been archived by the owner. It is now read-only.

Block server start until Cassandra is initialized #98

Merged
merged 3 commits into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Aug 15, 2017

The first request to Cassandra is very slow (on the order of 20 seconds
during my testing), I reckon because the connection and pool are being
built up. Subsequent requests are much faster (sub-second).

We don't want our users to have a problem with hitting the slow first
request, so we should warm up the Cassandra connection before we let the
server start. In this way, when we re-deploy the GraphQL server, we'll
simply continue running the instances of the old code in the load
balancer until the new server is fully operational and has warmed up the
Cassandra connection.

@c-w c-w requested review from Smarker and erikschlegel Aug 15, 2017

@c-w c-w force-pushed the server-start-blocker branch from e7af6e8 to 881249b Aug 15, 2017

@c-w c-w added the in progress label Aug 15, 2017

@Smarker
Copy link
Contributor

left a comment

LGTM

c-w added some commits Aug 15, 2017

Block server start until Cassandra is initialized
The first request to Cassandra is very slow (on the order of 20 seconds
during my testing), I reckon because the connection and pool are being
built up. Subsequent requests are much faster (sub-second).

We don't want our users to have a problem with hitting the slow first
request, so we should warm up the Cassandra connection before we let the
server start. In this way, when we re-deploy the GraphQL server, we'll
simply continue running the instances of the old code in the load
balancer until the new server is fully operational and has warmed up the
Cassandra connection.

@c-w c-w force-pushed the server-start-blocker branch from 6be9184 to c595ac0 Aug 15, 2017

@c-w c-w merged commit fc08166 into master Aug 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the server-start-blocker branch Aug 15, 2017

@c-w c-w removed the in progress label Aug 15, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.