This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Ensure that a single Cassandra connector is shared - #107
Merged
Conversation
c-w
force-pushed
the
cassandra-implicit-connector
branch
from
August 25, 2017 00:15
145bd42 to
e902a90
Compare
|
|
||
| // Main starts here | ||
| val ssc = StreamingContext.getOrCreate(fortisSettings.progressDir, createStreamingContext) | ||
| implicit val connector: CassandraConnector = CassandraConnector(ssc.sparkContext) |
Contributor
There was a problem hiding this comment.
Nothing will bind to this here. How about putting this inside CassandraEventsSink.apply and making it lazy as well (to ensure it doesn't get re-serialized for every task)?
c-w
force-pushed
the
cassandra-implicit-connector
branch
from
August 25, 2017 00:32
e902a90 to
b889974
Compare
kevinhartman
approved these changes
Aug 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per conversation in Slack. Still needs to be perf-tested to see if there's an improvement. (In any case it shouldn't hurt.)