Skip to content
This repository has been archived by the owner. It is now read-only.

Add granularity to sub-metrics, add overall metric #112

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Aug 25, 2017

No description provided.

@c-w c-w requested a review from kevinhartman Aug 25, 2017

@c-w c-w added the in progress label Aug 25, 2017

@@ -120,24 +122,24 @@ object CassandraEventsSink{
}

def aggregateEventBatch(eventDS: Dataset[Event], session: SparkSession, aggregator: FortisAggregator): Unit = {
val flattenedDF = Timer.time(Telemetry.logSinkPhase("flattenedDF", _, _, -1)) {
val flattenedDF = Timer.time(Telemetry.logSinkPhase(s"flattenedDF-${aggregator.FortisTargetTablename}", _, _, -1)) {

This comment has been minimized.

Copy link
@kevinhartman

kevinhartman Aug 25, 2017

Contributor

nit: we're using _ for aggregate above

@c-w c-w merged commit 221c653 into master Aug 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the more-logging branch Aug 25, 2017

@c-w c-w removed the in progress label Aug 25, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.