Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Remove bad exception for unset shared locations #124

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Sep 5, 2017

This looks like the results of a bad merge; what reason would we have to throw an exception regarding pageIds when checking the shared locations in a Facebook post? Seems more sensible to simply treat posts without a tagged location as not having shared locations.

@c-w c-w requested a review from jcjimenez September 5, 2017 06:48
@c-w c-w added the in progress label Sep 5, 2017
Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This looks like the results of a bad merge; what reason would we have to
throw an exception regarding pageIds when checking the shared locations
in a Facebook post? Seems more sensible to simply treat posts without a
tagged location as not having shared locations.
@c-w c-w merged commit 3dacf3f into master Sep 5, 2017
@c-w c-w deleted the facebook-locations branch September 5, 2017 13:00
@c-w c-w removed the in progress label Sep 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants