This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Remove bad exception for unset shared locations#124
Merged
Conversation
This looks like the results of a bad merge; what reason would we have to throw an exception regarding pageIds when checking the shared locations in a Facebook post? Seems more sensible to simply treat posts without a tagged location as not having shared locations.
c-w
force-pushed
the
facebook-locations
branch
from
ee5cf7d to
7d6988d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like the results of a bad merge; what reason would we have to throw an exception regarding pageIds when checking the shared locations in a Facebook post? Seems more sensible to simply treat posts without a tagged location as not having shared locations.