Skip to content
This repository has been archived by the owner. It is now read-only.

Remove bad exception for unset shared locations #124

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Sep 5, 2017

This looks like the results of a bad merge; what reason would we have to throw an exception regarding pageIds when checking the shared locations in a Facebook post? Seems more sensible to simply treat posts without a tagged location as not having shared locations.

@c-w c-w requested a review from jcjimenez Sep 5, 2017

@c-w c-w added the in progress label Sep 5, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM

Remove bad exception for unset shared locations
This looks like the results of a bad merge; what reason would we have to
throw an exception regarding pageIds when checking the shared locations
in a Facebook post? Seems more sensible to simply treat posts without a
tagged location as not having shared locations.

@c-w c-w force-pushed the facebook-locations branch from ee5cf7d to 7d6988d Sep 5, 2017

@c-w c-w merged commit 3dacf3f into master Sep 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the facebook-locations branch Sep 5, 2017

@c-w c-w removed the in progress label Sep 5, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.