Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Ensure that place centroids are set in Cassandra #125

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Sep 5, 2017

This requires two pieces:

  1. A feature recently was added to the featureService that enables the return of the centroid of a place using ST_Centroid in PostGIS. You can find a sample featureService request that includes place centroids in the response at https://aka.ms/b5ldsw. This feature is now integrated in the Spark pipeline so that we augment all detected locations with their WOF ids and their centroids.

  2. The Cassandra aggregation logic and downstream GraphQL services assume that the centroid of places are always set. As such, we shouldn't represent the place coordinates in Spark as Optionals.

Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This requires two pieces:

1) A feature recently was added to the featureService that enables the
return of the centroid of a place using ST_Centroid in PostGIS. You can
find a sample featureService request that includes place centroids in
the response at https://aka.ms/b5ldsw.  This feature is now integrated
in the Spark pipeline so that we augment all detected locations with
their WOF ids and their centroids.

2) The Cassandra aggregation logic and downstream GraphQL services
assume that the centroid of places are always set. As such, we shouldn't
represent the place coordinates in Spark as Optionals.
@c-w c-w merged commit 0d83319 into master Sep 5, 2017
@c-w c-w deleted the fix-place-centroids branch September 5, 2017 13:08
@c-w c-w removed the in progress label Sep 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants