Skip to content
This repository has been archived by the owner. It is now read-only.

Ensure that place centroids are set in Cassandra #125

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Sep 5, 2017

This requires two pieces:

  1. A feature recently was added to the featureService that enables the return of the centroid of a place using ST_Centroid in PostGIS. You can find a sample featureService request that includes place centroids in the response at https://aka.ms/b5ldsw. This feature is now integrated in the Spark pipeline so that we augment all detected locations with their WOF ids and their centroids.

  2. The Cassandra aggregation logic and downstream GraphQL services assume that the centroid of places are always set. As such, we shouldn't represent the place coordinates in Spark as Optionals.

@c-w c-w requested a review from erikschlegel Sep 5, 2017

@c-w c-w added the in progress label Sep 5, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM

Ensure that place centroids are set in Cassandra
This requires two pieces:

1) A feature recently was added to the featureService that enables the
return of the centroid of a place using ST_Centroid in PostGIS. You can
find a sample featureService request that includes place centroids in
the response at https://aka.ms/b5ldsw.  This feature is now integrated
in the Spark pipeline so that we augment all detected locations with
their WOF ids and their centroids.

2) The Cassandra aggregation logic and downstream GraphQL services
assume that the centroid of places are always set. As such, we shouldn't
represent the place coordinates in Spark as Optionals.

@c-w c-w force-pushed the fix-place-centroids branch from 0e745af to e6b7cd5 Sep 5, 2017

@c-w c-w merged commit 0d83319 into master Sep 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-place-centroids branch Sep 5, 2017

@c-w c-w removed the in progress label Sep 5, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.