This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Ensure that place centroids are set in Cassandra #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires two pieces: 1) A feature recently was added to the featureService that enables the return of the centroid of a place using ST_Centroid in PostGIS. You can find a sample featureService request that includes place centroids in the response at https://aka.ms/b5ldsw. This feature is now integrated in the Spark pipeline so that we augment all detected locations with their WOF ids and their centroids. 2) The Cassandra aggregation logic and downstream GraphQL services assume that the centroid of places are always set. As such, we shouldn't represent the place coordinates in Spark as Optionals.
c-w
force-pushed
the
fix-place-centroids
branch
from
0e745af to
e6b7cd5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires two pieces:
A feature recently was added to the featureService that enables the return of the centroid of a place using
ST_Centroidin PostGIS. You can find a sample featureService request that includes place centroids in the response at https://aka.ms/b5ldsw. This feature is now integrated in the Spark pipeline so that we augment all detected locations with their WOF ids and their centroids.The Cassandra aggregation logic and downstream GraphQL services assume that the centroid of places are always set. As such, we shouldn't represent the place coordinates in Spark as Optionals.