Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Wire-up featureService namespace filter#141

Merged
c-w merged 2 commits into
masterfrom
filter-namespace
Sep 12, 2017
Merged

Wire-up featureService namespace filter#141
c-w merged 2 commits into
masterfrom
filter-namespace

Conversation

@c-w
Copy link
Copy Markdown
Contributor

@c-w c-w commented Sep 12, 2017

As per conversation with @erikschlegel.

@c-w c-w requested a review from kevinhartman September 12, 2017 14:47
jcjimenez
jcjimenez approved these changes Sep 12, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 awyeah

@c-w
Copy link
Copy Markdown
Contributor Author

c-w commented Sep 12, 2017

Going to wait on a review from @kevinhartman since this touches the transform context code.

@c-w c-w merged commit c657aae into master Sep 12, 2017
@c-w c-w removed the in progress label Sep 12, 2017
@c-w c-w deleted the filter-namespace branch September 12, 2017 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jcjimenez jcjimenez jcjimenez approved these changes

@kevinhartman kevinhartman kevinhartman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-w @jcjimenez @kevinhartman