This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Conversation
Unfortunately we can't use Kryo serializer for all classes (via setting "spark.kryo.registrationRequired") because some classes that we depend upon are non-public (e.g. TwitterReceiver) so we can't easily get a handle to them to register them in Kryo.
c-w
force-pushed
the
improve-serialization
branch
from
43391b2 to
a3ed4fc
Compare
kevinhartman
approved these changes
Jun 21, 2017
Contributor
kevinhartman
left a comment
kevinhartman
left a comment
There was a problem hiding this comment.
LGTM. Perhaps we can register some internal classes using reflection in a later PR?
Contributor
Author
|
I did some research and didn't find anyone doing this. From my understanding, it's usually good enough to use Kryo for the commonly serialized data types (i.e., the DTOs) and keep using the Java serializer for less common types (like Receivers). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches our Spark setup to using the Kryo serializer for common DTO classes.
Unfortunately we can't enforce the use of the Kryo serializer for all classes (via the setting
spark.kryo.registrationRequired) because some classes that we depend upon are non-public so we can't easily get a handle to them to register them in Kryo (e.g. TwitterReceiver).Resolves #15