This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Conversation
c-w
force-pushed
the
extract-entities
branch
2 times, most recently
from
dfac34a to
4f00634
Compare
kevinhartman
approved these changes
Jun 22, 2017
|
|
||
| import scala.collection.JavaConversions._ | ||
| import scala.util.{Failure, Success, Try} | ||
| import com.microsoft.partnercatalyst.fortis.spark.transforms.nlp.OpeNER.entityIsPlace |
Contributor
There was a problem hiding this comment.
nit: In this case, I think qualifying the name inline would make it more obvious to the reader that this helper is part of OpeNER.
|
|
||
| def extractPeople(text: String, language: String): List[Tag] = { | ||
| entityRecognizer.extractEntities(text, language).filter(entityIsPerson) | ||
| .map(entity => Tag(name = entity.getStr, confidence = 1.0)) |
Contributor
There was a problem hiding this comment.
For my own understanding, why are we using tags for people but not place entities?
Contributor
Author
There was a problem hiding this comment.
Yeah, not happy with that inconsistency too. Fixed in e0daddc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cassandra schema contains a field for entities separate from places so this pull request ensures that we have the necessary data available to write the entity information to Cassandra.