Skip to content
This repository has been archived by the owner. It is now read-only.

Add Bing connector #25

Merged
merged 2 commits into from Jun 22, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jun 22, 2017

Resolves #5

@c-w c-w requested a review from kevinhartman Jun 22, 2017

@c-w c-w added the in progress label Jun 22, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM with minor observation

Map(
"accessToken" -> System.getenv("BING_ACCESS_TOKEN"),
"searchInstanceId" -> System.getenv("BING_SEARCH_INSTANCE_ID"),
"keywords" -> "isis|attack"

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Jun 22, 2017

Contributor

Not a deal-breaker, but may I suggest Option(System.getenv("BING_SEARCH_KEYWORDS")).getOrElse("isis|attack") instead of the raw term?

This comment has been minimized.

Copy link
@c-w

c-w Jun 22, 2017

Author Member

Good comment. These values are just here for testing purposes for now so they're fine to be hard-coded (see also all the other hard-coded values in this section). We'll get rid of them soon and in production, we'll populate the configs from Cassandra which is what Kevin is about to implement.

This comment has been minimized.

Copy link
@jcjimenez

jcjimenez Jun 22, 2017

Contributor

Perfect!

@jcjimenez jcjimenez merged commit 3217caf into master Jun 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jcjimenez jcjimenez removed the in progress label Jun 22, 2017

@c-w c-w deleted the bing-connector branch Jun 22, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.