Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Add Bing connector #25

Merged
merged 2 commits into from Jun 22, 2017
Merged

Add Bing connector #25

merged 2 commits into from Jun 22, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jun 22, 2017

Resolves #5

@c-w c-w requested a review from kevinhartman June 22, 2017 16:13
Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor observation

Map(
"accessToken" -> System.getenv("BING_ACCESS_TOKEN"),
"searchInstanceId" -> System.getenv("BING_SEARCH_INSTANCE_ID"),
"keywords" -> "isis|attack"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a deal-breaker, but may I suggest Option(System.getenv("BING_SEARCH_KEYWORDS")).getOrElse("isis|attack") instead of the raw term?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comment. These values are just here for testing purposes for now so they're fine to be hard-coded (see also all the other hard-coded values in this section). We'll get rid of them soon and in production, we'll populate the configs from Cassandra which is what Kevin is about to implement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@jcjimenez jcjimenez merged commit 3217caf into master Jun 22, 2017
@c-w c-w deleted the bing-connector branch June 22, 2017 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants