Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Remove comment that causes warning on sbt assembly #32

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Remove comment that causes warning on sbt assembly #32

merged 1 commit into from
Jun 27, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jun 27, 2017

No description provided.

@kevinhartman kevinhartman self-requested a review June 27, 2017 15:38
kevinhartman
kevinhartman approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@kevinhartman kevinhartman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Interesting. What's the warning here?

@c-w
Copy link
Contributor Author

c-w commented Jun 27, 2017 •
edited
Loading

I didn't grab the console output, but it was something about something not being a valid target. Anyways, the comment doesn't add much value on top of the method signature, so good riddance to it. Less green is always a good thing.

@c-w c-w merged commit 83e8710 into master Jun 27, 2017
@c-w c-w deleted the fix-javadoc branch June 27, 2017 16:31
@c-w c-w removed the in progress label Jun 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinhartman kevinhartman kevinhartman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-w @kevinhartman