Skip to content
This repository has been archived by the owner. It is now read-only.

Remove comment that causes warning on sbt assembly #32

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jun 27, 2017

No description provided.

@c-w c-w added the in progress label Jun 27, 2017

@kevinhartman kevinhartman self-requested a review Jun 27, 2017

@kevinhartman
Copy link
Contributor

left a comment

LGTM. Interesting. What's the warning here?

@c-w

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2017

I didn't grab the console output, but it was something about something not being a valid target. Anyways, the comment doesn't add much value on top of the method signature, so good riddance to it. Less green is always a good thing.

@c-w c-w merged commit 83e8710 into master Jun 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-javadoc branch Jun 27, 2017

@c-w c-w removed the in progress label Jun 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.